Site with some issues and improvements

luisherranz · 22 September 2020 08:47

That warning seems to be from the Link component.

Divaksh · 23 September 2020 12:02

Can I move modified core to packages directory? or Does this mean we can’t use material-ui with Frontity on the Vercel?

luisherranz · 24 September 2020 09:43

You have to use something like https://github.com/ds300/patch-package from now.

furrysmile2 · 25 September 2020 01:57

luisherranz:

The useEffect to delete the CSS on the client can be added in your own theme, it doesn’t need to be in core:
React.useEffect(() => {
    const jssStyles = document.querySelector('#jss-server-side');
    if (jssStyles) {
      jssStyles.parentNode.removeChild(jssStyles);
    }
  }, []);

'document' is not defined. It shows this error on client

furrysmile2 · 12 November 2020 16:56

Urgent: frontity.style is no longer in index.ts because of your updates, so where to add this:

frontity.style = <style amp-custom>${emotion.css}</style> <style id="jss-server-side">${materialCss}</style> ;

luisherranz · 13 November 2020 11:28

@furrysmile2 I would just copy the file again (https://github.com/frontity/frontity/blob/dev/packages/core/src/server/index.tsx) and then add the style to the frontity object because it gets sent to the template.

As you can see, the frontity.style prop still exists in the template file: https://github.com/frontity/frontity/blob/dev/packages/core/src/server/templates/html.ts#L16

francis · 13 November 2020 18:36

I might be a bit late into this but I’m working on implementing Material UI.
I believe emotion.css also moved from index.tsx so curious if that’s covered somewhere else and we can just put: ${materialCss}?

furrysmile2 · 15 November 2020 06:12

yes we can

francis · 15 November 2020 06:24

Thanks. I got it actually working now and it’s working smoothly. Also added serverGenerateClassName to clean things up a bit.

rborowski.shovv · 17 December 2020 11:50

this issue with correctly rendering material-ui in theme is solved with package ?

furrysmile2 · 17 December 2020 14:10

Yes just edit and run this https://github.com/ds300/patch-package

francis · 13 March 2021 17:03

Just following up on this as there has been changes with the recent patch from core
“@frontity/core”: “^1.11.0”,

Is there an OOTB solution for Material UI SSR support now?

francis · 11 April 2021 23:26

By any chance, you can provide a guide on how to do this since https://github.com/frontity/frontity/blob/dev/packages/core/src/server/index.tsx has changed?

luisherranz · 16 April 2021 07:28

@cristianbote has made a CodeSanbox explaining how to do this in this other thread: Integrate Material-UI server side rendered - #6 by cristianbote

Let’s continue the discussion there instead